-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set parameters from file for composable nodes #281
Set parameters from file for composable nodes #281
Conversation
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with this TODO resolved:
launch_ros/test_launch_ros/test/test_launch_ros/actions/test_set_parameters_from_file.py
Line 136 in d31044d
# TODO: (Aditya) Add test case for composable node |
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
CI round 2 : Windows failures seem to be unrelated : https://ci.ros2.org/view/All/job/ci_windows/15761/#showFailuresLink |
Looks life a flaky failure. @jacobperron should I merge this ? |
LGTM, go ahead and merge 🎉 |
This PR aims to extend the
SetParametersFromFile
launch action to composable nodes as well.Sample usage :
TODO :
Signed-off-by: Aditya Pande aditya050995@gmail.com