Add regex filter for selective launch-prefix application #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a rebase. |
added 3 commits
August 24, 2021 17:47
… configuration Signed-off-by: Cameron Miller <cammlle@amazon.com>
Signed-off-by: Cameron Miller <cammlle@amazon.com> Signed-off-by: Cameron Miller <cammlle@amazon.com> Signed-off-by: Cameron Miller <cammlle@amazon.com>
Signed-off-by: Cameron Miller <cammlle@amazon.com>
camm73
force-pushed
the
cameron/launch-prefix-filter
branch
from
9cfe393
to
ae037e6
Compare
|
Should be good to go now @hidmic. Thanks for reviewing all these PRs! |
hidmic
reviewed
Aug 30, 2021
Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com> Signed-off-by: Cameron Miller <cammlle@amazon.com>
Signed-off-by: Cameron Miller <cammlle@amazon.com>
camm73
force-pushed
the
cameron/launch-prefix-filter
branch
from
63a7abe
to
984a6f8
Compare
hidmic
approved these changes
Sep 3, 2021
Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com> Signed-off-by: Cameron Miller <cammlle@amazon.com>
camm73
force-pushed
the
cameron/launch-prefix-filter
branch
from
10dba68
to
ae91d0e
Compare
Signed-off-by: Cameron Miller <cammlle@amazon.com>
My flake8 didn't flag a quote issue in |
|
CI, take two:
|
|
Alright, all green. Going in. |
87 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #257
This PR shouldn't be merged until #254 and ros2/launch#522 have been accepted and merged.
This PR adds the
--launch-prefix-filterargument discussed in #257 which allows the user to provide a regex pattern that can be used for selectively applying the command prefix (provided via the--launch-prefixargument) to executables which match the pattern. This will allow an easier debugging experience without having to edit the launch file.