Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support both parameter file configurations for composable nodes #259

Merged
merged 11 commits into from
Oct 23, 2021
Merged

Support both parameter file configurations for composable nodes #259

merged 11 commits into from
Oct 23, 2021

Commits on Aug 13, 2021

  1. Support both param file configurations in to_parameters_list.py 

    Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
    @rebecca-butler
    rebecca-butler committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    6c411aa View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2021

  1. Support another file config and add tests 

    Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
    @rebecca-butler
    rebecca-butler committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    97ede21 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2021

  1. Update to work for multiple entries in yaml 

    Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
    @rebecca-butler
    rebecca-butler committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    4aebebd View commit details
    Browse the repository at this point in the history

  2. Fix deleted line 

    Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
    @rebecca-butler
    rebecca-butler committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    3eabbe4 View commit details
    Browse the repository at this point in the history

  3. Remove duplicated line 

    Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
    @rebecca-butler
    rebecca-butler committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    0ddbb46 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. Address reviewer comments 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    e6de211 View commit details
    Browse the repository at this point in the history

  2. Emit warning iff no node name and ros__parameters foramt is used 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    1f1ed6e View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2021

  1. Refactor after review 

    - Rename private function for dealing with ros__parameters entries
- Keep recursive parameters internal to function
- Skip evaluating parameters if dictionary is empty
- Use isinstance
- Strip trailing and leading '/' from node namespace

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    9de0767 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2021

  1. Remove unnecessary line 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    5adffa8 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2021

  1. Reset keys list in case of dictionary value 

    We actually do this for the case of multiple entries like this:

    /ns_1:
      /node_1:
        ros__parameters:
          param_1: 1
          param_2: 2

    /**:
      ros__parameters:
        param_2: 22
        param_3: 33

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    c7844b5 View commit details
    Browse the repository at this point in the history

  2. Use separate test file for test_load_composable_nodes 

    Rather than reusing the test file that is used in test_node.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    bd1bc63 View commit details
    Browse the repository at this point in the history