Add and update security designs for Contexts #274

ruffsl · 2020-02-25T04:42:59Z

With the migration to contexts in ROS2 underway, I’ve been iterating with @mikaelarguedas on adjustments to SROS2 tooling to accommodate this mapping of nodes to participants (ruffsl#1). This PR proposes relevant changes to the keystore layout, security directory lookup, and policy schema.

Related tickets:

Feel free to ping any interested parties I've missed from scraping the above ticket discussions.

Signed-off-by: ruffsl <roxfoxpox@gmail.com> Co-Authored-By: Mikael Arguedas <mikael.arguedas@gmail.com>

ros-discourse · 2020-02-25T04:46:19Z

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-security-working-group-meeting-02-25-2020/12958/2

ivanpauno

Some comments and questions, but it's looking good.

articles/ros2_access_control_policies.md

articles/ros2_security_contexts.md

kyrofa

I haven't quite made it through the whole thing, but a few quick comments from me.

articles/ros2_access_control_policies.md

articles/ros2_dds_security.md

articles/ros2_security_contexts.md

Co-Authored-By: Kyle Fazzari <kyle@canonical.com>

ivanpauno · 2020-04-09T16:48:17Z

To modify the names used in the API, changes in rcl, sros2 and system_tests are needed.
To completely delete the security_context word from implementation details, PRs to rmw, rmw_implementation and the specific rmw implementations will also be needed.

@ruffsl @mikaelarguedas Let me know if you can open PRs for the re-naming.

mikaelarguedas · 2020-04-09T22:18:26Z

Let me know if you can open PRs for the re-naming.

@ivanpauno I took a stab at this:
ros2/rcl#612
ros2/rmw#211
ros2/rmw_connext#407
ros2/rmw_cyclonedds#146
ros2/rmw_dds_common#13
ros2/rmw_implementation#91
ros2/rmw_fastrtps#365
ros2/sros2#198
ros2/system_tests#414

Repos file at https://gist.githubusercontent.com/mikaelarguedas/cd1009797d836e6d46a0f6d12b1cc05d/raw/2770591673f28d73d21ea5d432d939fee171e75d/enclaves.repos

Linux
Linux-aarch64
macOS
Windows

ruffsl · 2020-04-10T02:19:37Z

#274 (comment)

I think we can do the aircraft control to track these and other PRs in flight over on ros2/sros2#182 .

dirk-thomas · 2020-04-10T05:07:50Z

@mikaelarguedas I aborted the Windows build since it was stuck for 1+h on ros2topic tests.

articles/150_ros_command_line_arguments.md

ivanpauno · 2020-04-13T13:32:27Z

@mikaelarguedas @ruffsl Do you think there is anything else missing to merge this?

ruffsl · 2020-04-14T04:45:54Z

@ivanpauno, one last bit. I've added two commits to update the environment variables.
Related:

ivanpauno · 2020-04-14T12:32:09Z

@ivanpauno, one last bit. I've added two commits to update the environment variables.
Related:

ros2/sros2#199

#274 (comment)

The renaming sounds good to me.
If the rest of the security working group agrees, I will go ahead an run CI/merge.

mikaelarguedas · 2020-04-14T14:12:17Z

one last bit. I've added two commits to update the environment variables.

As discussed on Matrix, if we rename the variables associated to the keystore, I believe we should rename it everywhere and remove any mention to "secure_root". Currently this only renames the env variables and not the associated datastructures and functions

Do you think there is anything else missing to merge this?

I think we would benefit from an "Enclaves" sub-section in the "Concepts" section, however I won't have time to work on that today

ruffsl · 2020-04-14T15:18:25Z

I believe we should rename it everywhere and remove any mention to "secure_root".

I left the associated data structures and functions alone for the time being as file system paths are at present the only current supported keystore URI. I also couldn't think of a better substitute term given most of the functions and tests where file system oriented.

ivanpauno · 2020-04-14T16:48:37Z

As discussed on Matrix, if we rename the variables associated to the keystore, I believe we should rename it everywhere and remove any mention to "secure_root".

Sounds good.
I will run CI, when the current failures are solved.

Currently this only renames the env variables and not the associated datastructures and functions

Though I agree an update would be good, that API is not directly used by the user, and the only thing that the user get access is the environment variable names.
So, I'm ok with only updating the env variable names for now.

I think we would benefit from an "Enclaves" sub-section in the "Concepts" section, however I won't have time to work on that today

Sounds good.

ruffsl · 2020-05-20T18:50:20Z

one last bit. I've added two commits to update the environment variables

Now that those have been merged, I'll merge here as well so that the security design is up to date.

* Add initial draft for ROS 2 Security Contexts Signed-off-by: ruffsl <roxfoxpox@gmail.com> Co-Authored-By: Mikael Arguedas <mikael.arguedas@gmail.com> * Update policy schema for contexts * Update DDS-Security integration for contexts * Allow contexts to formalize cross domain bridging * Update context vocab * Update design for runtime argument * Simplify context arg * Removing shell specific $ from variables * Restore notes on synlinks * Remove the use of alternate lookup methods It's now redundan given context paths can be independent of namespace ros2#274 (comment) * Update policy schema to match that currently used * Update key argument name for security context * Publish Security Contexts document * Update context directory overide env name * Update story for ROS_SECURITY_ROOT_DIRECTORY * Context -> Enclave * Rename for enclave terminology change * Update runtime argument for enclave assignment * Relegate lunch interrogation to future work * Disassociate context paths from namespaces * Update override example of root directory and CLA * Rename security environment variables * Update behavor of ROS_SECURITY_ENCLAVE_OVERRIDE Co-authored-by: Mikael Arguedas <mikael.arguedas@gmail.com> Co-authored-by: Kyle Fazzari <kyle@canonical.com>

ruffsl and others added 3 commits February 24, 2020 20:24

Add initial draft for ROS 2 Security Contexts

0f94ed2

Signed-off-by: ruffsl <roxfoxpox@gmail.com> Co-Authored-By: Mikael Arguedas <mikael.arguedas@gmail.com>

Update policy schema for contexts

4dd1ae2

Update DDS-Security integration for contexts

7886859

ruffsl requested review from wjwwood, gbiggs, mjcarroll, kyrofa, jacobperron, dirk-thomas, hidmic and ivanpauno February 25, 2020 04:42

ruffsl mentioned this pull request Feb 25, 2020

Add initial draft for ROS 2 Security Contexts ruffsl/design#1

Closed

dirk-thomas removed their request for review February 25, 2020 05:11

ivanpauno reviewed Feb 26, 2020

View reviewed changes

ruffsl added 3 commits February 26, 2020 22:55

Fix typo

f2a3c2b

Fix typo

735d278

Fix typo

853c2b3

This comment has been minimized.

Sign in to view

kyrofa reviewed Feb 27, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

ruffsl and others added 4 commits February 27, 2020 14:29

Editorial rephrasing

ea11d70

Co-Authored-By: Kyle Fazzari <kyle@canonical.com>

Fix typo

1f72771

Co-Authored-By: Kyle Fazzari <kyle@canonical.com>

Editorial rephrasing

9eef58c

Co-Authored-By: Kyle Fazzari <kyle@canonical.com>

Editorial rephrasing

8da5c02

This comment has been minimized.

Sign in to view

ruffsl added 4 commits April 9, 2020 13:30

Relegate lunch intertraion to future work

3e148b2

Disassociate context paths from namespaces

e4b4ad4

Correct terms

a206b1a

Fix grammar

134f3e1

ruffsl added 3 commits April 9, 2020 15:30

Editorial rephrasing

8f7fac9

Update override example of root directory and CLA

ea400f6

Editorial clarifications

d29e06a

ruffsl requested review from ivanpauno, mikaelarguedas, artivis and kyrofa April 10, 2020 02:22

mikaelarguedas mentioned this pull request Apr 10, 2020

security-context -> enclave ros2/rcl#612

Merged

ivanpauno reviewed Apr 10, 2020

View reviewed changes

articles/150_ros_command_line_arguments.md Show resolved Hide resolved

ruffsl added 2 commits April 13, 2020 21:34

Rename security environment variables

cec67f6

Update behavor of ROS_SECURITY_ENCLAVE_OVERRIDE

98200d8

ruffsl merged commit fca6752 into gh-pages May 20, 2020

delete-merged-branch bot deleted the security-contexts branch May 20, 2020 18:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add and update security designs for Contexts #274

Add and update security designs for Contexts #274

ruffsl commented Feb 25, 2020

ros-discourse commented Feb 25, 2020

ivanpauno left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

kyrofa left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ivanpauno commented Apr 9, 2020

mikaelarguedas commented Apr 9, 2020 •

edited

Loading

ruffsl commented Apr 10, 2020

dirk-thomas commented Apr 10, 2020

ivanpauno commented Apr 13, 2020

ruffsl commented Apr 14, 2020

ivanpauno commented Apr 14, 2020

mikaelarguedas commented Apr 14, 2020 •

edited

Loading

ruffsl commented Apr 14, 2020

ivanpauno commented Apr 14, 2020

ruffsl commented May 20, 2020

Add and update security designs for Contexts #274

Add and update security designs for Contexts #274

Conversation

ruffsl commented Feb 25, 2020

ros-discourse commented Feb 25, 2020

ivanpauno left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

kyrofa left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ivanpauno commented Apr 9, 2020

mikaelarguedas commented Apr 9, 2020 • edited Loading

ruffsl commented Apr 10, 2020

dirk-thomas commented Apr 10, 2020

ivanpauno commented Apr 13, 2020

ruffsl commented Apr 14, 2020

ivanpauno commented Apr 14, 2020

mikaelarguedas commented Apr 14, 2020 • edited Loading

ruffsl commented Apr 14, 2020

ivanpauno commented Apr 14, 2020

ruffsl commented May 20, 2020

mikaelarguedas commented Apr 9, 2020 •

edited

Loading

mikaelarguedas commented Apr 14, 2020 •

edited

Loading