-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added README.md for composition #598
Conversation
Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
…er explainations for Run sub-sections. Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
…ode. Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me. I've added a few small fixes.
Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! @mjeronimo, want to do one last pass?
Yes, I'll take a look... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with one minor suggestion.
Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
Purpose of Pull Request
This pull request adds a
README.md
to composition as part of efforts to address the issue highlighted in #531.