-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rclpy QoS Demos (Liveliness, Lifespan, Deadline) #338
Conversation
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
…istory messages when a subscriber comes online, lifespan setting or no Signed-off-by: Emerson Knapp <eknapp@amazon.com>
from rclpy.qos_event import PublisherEventCallbacks | ||
from rclpy.qos_event import SubscriptionEventCallbacks | ||
|
||
POLICY_MAP = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recently did something similar for reliability/durability in ros2topic
: https://github.com/ros2/ros2cli/blob/a2d73c07f0245744e3d8e08d153752058470c9b4/ros2topic/ros2topic/api/__init__.py#L143
Would it make sense to centralize these in rclpy
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense to me to centralize it. I can take a crack at that today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I have created
ros2/rclpy#352
ros2/ros2cli#240
to address this, but I won't change this PR until that has been agreed on. This will work as-is for the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can apply this change his in a follow-up PR.
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
…. Rename cpp cmake project name Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
I have taken this out of draft, it is now ready for review - a few notes on limitations
|
@dirk-thomas is this something that we want to track on the distro freeze board? https://github.com/orgs/ros2/projects/5 |
This needs to land as soon as possible to be considered during the testing phase. The distro freeze is too late to aim for for this to land. |
@jacobperron @sloretz could either of you take a look at this PR? or suggest somebody appropriate to review it? |
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add demos for QoS policies in rclpy, for parity with the C++
quality_of_service_demo
quality_of_service_demo_cpp