Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change #if to #ifdef #234

Merged
merged 1 commit into from
May 1, 2018
Merged

Change #if to #ifdef #234

merged 1 commit into from
May 1, 2018

Conversation

mjcarroll
Copy link
Member

@mjcarroll mjcarroll commented Apr 26, 2018 •
edited
Loading

Connects to ros2/rcl#229

@mjcarroll mjcarroll added the in progress Actively being worked on (Kanban column) label Apr 26, 2018
mikaelarguedas
mikaelarguedas approved these changes Apr 26, 2018
View reviewed changes
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with green CI covering all packages

@mjcarroll mjcarroll merged commit 6bd7598 into master May 1, 2018
@mjcarroll mjcarroll deleted the misra_fixup branch May 1, 2018 22:22
@mjcarroll mjcarroll removed the in progress Actively being worked on (Kanban column) label May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjcarroll @mikaelarguedas