Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add subscriber to flip image #2

Merged
merged 2 commits into from
Jul 30, 2015
Merged

add subscriber to flip image #2

merged 2 commits into from
Jul 30, 2015

Conversation

dirk-thomas
Copy link
Member

No description provided.

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Jul 30, 2015
@dirk-thomas dirk-thomas self-assigned this Jul 30, 2015
@esteve esteve mentioned this pull request Jul 30, 2015
@esteve
Copy link
Member

esteve commented Jul 30, 2015

+1, please squash the commits before merging

@dirk-thomas
Copy link
Member Author

Since both commits change different things which are not related to each other I would rather keep them as separate commits.

@esteve
Copy link
Member

esteve commented Jul 30, 2015

@dirk-thomas no problem.

@wjwwood
Copy link
Member

wjwwood commented Jul 30, 2015

+1

dirk-thomas added a commit that referenced this pull request Jul 30, 2015
add subscriber to flip image
@dirk-thomas dirk-thomas merged commit 0066b1d into master Jul 30, 2015
@dirk-thomas dirk-thomas deleted the flip_image_option branch July 30, 2015 19:31
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants