Pass through c++ build flags #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
This comment has been minimized.
This comment has been minimized.
|
@emersonknapp console_bridge_vendor is missing the logic to force the build even if the upstream package is found. I expect this is because none of our current platforms provide a suitable upstream version at the moment but since that will change with platform updates it'd be great to introduce that feature here. With the update discussed in ros2/poco_vendor#24 (comment) |
3 tasks
nuclearsandwich
approved these changes
Mar 20, 2019
nuclearsandwich
added
in review
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Emerson Knapp eknapp@amazon.com
Related to ros2/ros2#664
connects to ros2/poco_vendor#24