Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

combine 'ws' and 'work space' pattern since Jenkins requires them to be non-empty #479

Merged
merged 1 commit into from
Jun 17, 2020
Merged

combine 'ws' and 'work space' pattern since Jenkins requires them to be non-empty #479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions job_templates/snippet/publisher_warnings_ng.xml.em
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,49 +1,47 @@
<io.jenkins.plugins.analysis.core.steps.IssuesRecorder plugin="warnings-ng@@7.3.0">
<analysisTools>
@[for workspace in ['ws', 'work space']]@
<io.jenkins.plugins.analysis.warnings.Cmake>
<id></id>
<name></name>
<pattern>@(workspace)/log/build_*/*/stdout_stderr.log</pattern>
<pattern>*/log/build_*/*/stdout_stderr.log</pattern>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking something more precise like

Suggested change
<pattern>*/log/build_*/*/stdout_stderr.log</pattern>
<pattern>{ws,work space}/log/build_*/*/stdout_stderr.log</pattern>

I think it only matters if we notice these globs taking a long time to resolve.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that syntax is doing what you intend: Build Status which should have a compiler warning.

[GNU C Compiler (gcc)] [-ERROR-] No files found for pattern '{ws,work space}/log/build_//stdout_stderr.log'. Configuration error?

<reportEncoding></reportEncoding>
<skipSymbolicLinks>false</skipSymbolicLinks>
</io.jenkins.plugins.analysis.warnings.Cmake>
@[ if os_name in ['linux', 'linux-armhf', 'linux-aarch64', 'linux-centos']]@
@[if os_name in ['linux', 'linux-armhf', 'linux-aarch64', 'linux-centos']]@
<io.jenkins.plugins.analysis.warnings.Gcc4>
<id></id>
<name></name>
<pattern>@(workspace)/log/build_*/*/stdout_stderr.log</pattern>
<pattern>*/log/build_*/*/stdout_stderr.log</pattern>
<reportEncoding></reportEncoding>
<skipSymbolicLinks>false</skipSymbolicLinks>
</io.jenkins.plugins.analysis.warnings.Gcc4>
@[ end if]
@[ if os_name in ['osx', 'linux', 'linux-armhf', 'linux-aarch64', 'linux-centos']]@
@[end if]
@[if os_name in ['osx', 'linux', 'linux-armhf', 'linux-aarch64', 'linux-centos']]@
<io.jenkins.plugins.analysis.warnings.Clang>
<id></id>
<name></name>
<pattern>@(workspace)/log/build_*/*/stdout_stderr.log</pattern>
<pattern>*/log/build_*/*/stdout_stderr.log</pattern>
<reportEncoding></reportEncoding>
<skipSymbolicLinks>false</skipSymbolicLinks>
</io.jenkins.plugins.analysis.warnings.Clang>
<io.jenkins.plugins.analysis.warnings.ClangTidy>
<id></id>
<name></name>
<pattern>@(workspace)/log/build_*/*/stdout_stderr.log</pattern>
<pattern>*/log/build_*/*/stdout_stderr.log</pattern>
<reportEncoding></reportEncoding>
<skipSymbolicLinks>false</skipSymbolicLinks>
</io.jenkins.plugins.analysis.warnings.ClangTidy>
@[ elif os_name in ['windows', 'windows-metal']]@
@[elif os_name in ['windows', 'windows-metal']]@
<io.jenkins.plugins.analysis.warnings.MsBuild>
<id></id>
<name></name>
<pattern>@(workspace)/log/build_*/*/stdout_stderr.log</pattern>
<pattern>*/log/build_*/*/stdout_stderr.log</pattern>
<reportEncoding></reportEncoding>
<skipSymbolicLinks>false</skipSymbolicLinks>
</io.jenkins.plugins.analysis.warnings.MsBuild>
@[ else]@
@[else]@
@{assert False, 'Unknown os_name: ' + os_name}@
@[ end if]@
@[end for]@
@[end if]@
</analysisTools>
<sourceCodeEncoding></sourceCodeEncoding>
<sourceDirectory></sourceDirectory>
Expand Down