Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use _MSC_VER and support gcc on windows (mingw) #212

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

Use _MSC_VER and support gcc on windows (mingw) #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/class_loader/class_loader_core.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,12 +301,12 @@ registerPlugin(const std::string & class_name, const std::string & base_class_na

getPluginBaseToFactoryMapMapMutex().unlock();

#ifndef _WIN32
#ifndef _MSC_VER
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdelete-non-virtual-dtor"
#endif
delete (p); // Note: This is the only place where metaobjects can be destroyed
#ifndef _WIN32
#ifndef _MSC_VER
#pragma GCC diagnostic pop
#endif
});
Expand Down