Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore warnings about import/exports when deriving from std classes on MSVC #116

Merged
merged 4 commits into from
Jan 31, 2019
Merged

ignore warnings about import/exports when deriving from std classes on MSVC #116

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08fabf2
ignore dll import and export errors on msvc (#11)
kejxu Jan 18, 2019
2b37f64
add documentation links to compiler warnings
kejxu Jan 31, 2019
7bb6ac1
Update include/class_loader/visibility_control.hpp
nuclearsandwich Jan 31, 2019
d40a128
remove duplicate links
kejxu Jan 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions include/class_loader/visibility_control.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,13 @@
#define CLASS_LOADER_PUBLIC_TYPE
#endif

// based on wiki.ros.org: http://wiki.ros.org/win_ros/Contributing/Dll%20Exports
// Ignore warnings about import/exports when deriving from std classes.
kejxu marked this conversation as resolved.
Show resolved Hide resolved
// https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4251
// https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-2-c4275
#ifdef _MSC_VER
#pragma warning(disable: 4251)
#pragma warning(disable: 4275)
#endif

#endif // CLASS_LOADER__VISIBILITY_CONTROL_HPP_