Skip to content

Commit

Permalink
[linter] add nolint for global std::string used for testing (#79)
Browse files Browse the repository at this point in the history
Otherwise cpplint complains "For a static/global string constant, use a C style string instead"
  • Loading branch information
mikaelarguedas authored Feb 8, 2018
1 parent 192cbc2 commit 8a0f6c3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions test/unique_ptr_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@

#include "./base.h"

const std::string LIBRARY_1 = class_loader::systemLibraryFormat("class_loader_TestPlugins1");
const std::string LIBRARY_2 = class_loader::systemLibraryFormat("class_loader_TestPlugins2");
const std::string LIBRARY_1 = class_loader::systemLibraryFormat("class_loader_TestPlugins1"); // NOLINT
const std::string LIBRARY_2 = class_loader::systemLibraryFormat("class_loader_TestPlugins2"); // NOLINT

using class_loader::ClassLoader;

Expand Down
4 changes: 2 additions & 2 deletions test/utest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@

#include "./base.h"

const std::string LIBRARY_1 = class_loader::systemLibraryFormat("class_loader_TestPlugins1");
const std::string LIBRARY_2 = class_loader::systemLibraryFormat("class_loader_TestPlugins2");
const std::string LIBRARY_1 = class_loader::systemLibraryFormat("class_loader_TestPlugins1"); // NOLINT
const std::string LIBRARY_2 = class_loader::systemLibraryFormat("class_loader_TestPlugins2"); // NOLINT

TEST(ClassLoaderTest, basicLoad) {
try {
Expand Down

0 comments on commit 8a0f6c3

Please sign in to comment.