guard against multiply-defined tf warning macros #700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at least on Saucy+hydro, the compiler was complaining that these macros were multiply defined, and was halting the build. adding these "ifndef" blocks allowed it to build.
|
@CodeBot9000 any chance you remember the other place they were defined? I'll try to reproduce this on Saucy. |
|
codebot9000 does not have good memory.
|
wjwwood
added a commit
that referenced
this pull request
May 8, 2014
tf recently moved to boost::signal2, so the effort display needed to be updated too I made it so that it would conditionally use boost::signal2 if the tf version is greater than or equal to 1.11.3 I also fixed some compiler warnings in this code This code (the effort display) is actually pretty wicked... I commented on the original pull request which added it as a built-in display type closes #700
wjwwood
added a commit
that referenced
this pull request
May 8, 2014
tf recently moved to boost::signal2, so the effort display needed to be updated too I made it so that it would conditionally use boost::signal2 if the tf version is greater than or equal to 1.11.3 I also fixed some compiler warnings in this code This code (the effort display) is actually pretty wicked... I commented on the original pull request which added it as a built-in display type closes #700 fixup RVIZ_USE_BOOST_SIGNAL_1 cmake code
wjwwood
added a commit
that referenced
this pull request
Jul 30, 2014
tf recently moved to boost::signal2, so the effort display needed to be updated too I made it so that it would conditionally use boost::signal2 if the tf version is greater than or equal to 1.11.3 I also fixed some compiler warnings in this code This code (the effort display) is actually pretty wicked... I commented on the original pull request which added it as a built-in display type closes #700 fixup RVIZ_USE_BOOST_SIGNAL_1 cmake code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at least on Saucy+hydro, the compiler was complaining that these macros were multiply defined, and was halting the build. adding these "ifndef" blocks allowed it to build.