Use Python debug executable for Windows debug builds #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current patch doesn't address the failing tests. |
Use the package python_cmake_module to get the debug executable. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
Apparently Windows debug: |
|
The majority of rqt_py_common test failures seem to be resolved. The single test failure seems to be newly uncovered now that the others have been resolved. Edit: the test failure appears to be due to the absence of a debug build for PyQt5. I guess this should be done as part of our CI machine setup. |
dirk-thomas
approved these changes
Jun 6, 2019
The initial build has 13 tests with 11 failures. The latest one has 2 tests with 2 failures. So it isn't really clear to me that this is an improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the package python_cmake_module to get the debug executable.
Fixes
rqt_py_commonpytest failures on Windows debug builds. E.g. https://ci.ros2.org/job/ci_windows/6980/testReport/Windows debug: