Skip to content

Commit

Permalink
Shorten some excessively long lines of CMake (#99)
Browse files Browse the repository at this point in the history
The line length enforcement in ament_lint_cmake has been broken for some
time, but will be fixed by ament/ament_lint#236. This change brings this
package into compliance with a 120 column limit.

Signed-off-by: Scott K Logan <logans@cottsay.net>
  • Loading branch information
cottsay authored Feb 12, 2021
1 parent 7ff71b0 commit 0af15ba
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
12 changes: 10 additions & 2 deletions cmake/shiboken_helper.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,22 @@ endif()
macro(_shiboken_generator_command VAR GLOBAL TYPESYSTEM INCLUDE_PATH BUILD_DIR)
# Add includes from current directory, Qt, PySide and compiler specific dirs
get_directory_property(SHIBOKEN_HELPER_INCLUDE_DIRS INCLUDE_DIRECTORIES)
list(APPEND SHIBOKEN_HELPER_INCLUDE_DIRS ${QT_INCLUDE_DIR} ${PYSIDE_INCLUDE_DIR} ${CMAKE_CXX_IMPLICIT_INCLUDE_DIRECTORIES})
list(APPEND SHIBOKEN_HELPER_INCLUDE_DIRS
${QT_INCLUDE_DIR}
${PYSIDE_INCLUDE_DIR}
${CMAKE_CXX_IMPLICIT_INCLUDE_DIRECTORIES})
# See ticket https://code.ros.org/trac/ros-pkg/ticket/5219
set(SHIBOKEN_HELPER_INCLUDE_DIRS_WITH_COLONS "")
foreach(dir ${SHIBOKEN_HELPER_INCLUDE_DIRS})
set(SHIBOKEN_HELPER_INCLUDE_DIRS_WITH_COLONS "${SHIBOKEN_HELPER_INCLUDE_DIRS_WITH_COLONS}:${dir}")
endforeach()
string(REPLACE ";" ":" INCLUDE_PATH_WITH_COLONS "${INCLUDE_PATH}")
set(${VAR} ${SHIBOKEN_BINARY} --generatorSet=shiboken --enable-pyside-extensions --include-paths=${INCLUDE_PATH_WITH_COLONS}${SHIBOKEN_HELPER_INCLUDE_DIRS_WITH_COLONS} --typesystem-paths=${PYSIDE_TYPESYSTEMS} --output-directory=${BUILD_DIR} ${GLOBAL} ${TYPESYSTEM})
set(${VAR} ${SHIBOKEN_BINARY}
--generatorSet=shiboken
--enable-pyside-extensions
--include-paths=${INCLUDE_PATH_WITH_COLONS}${SHIBOKEN_HELPER_INCLUDE_DIRS_WITH_COLONS}
--typesystem-paths=${PYSIDE_TYPESYSTEMS}
--output-directory=${BUILD_DIR} ${GLOBAL} ${TYPESYSTEM})
endmacro()


Expand Down
3 changes: 2 additions & 1 deletion cmake/sip_helper.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ function(build_sip_binding PROJECT_NAME SIP_FILE)

add_custom_command(
OUTPUT ${SIP_BUILD_DIR}/Makefile
COMMAND ${PYTHON_EXECUTABLE} ${sip_SIP_CONFIGURE} ${SIP_BUILD_DIR} ${SIP_FILE} ${sip_LIBRARY_DIR} \"${INCLUDE_DIRS}\" \"${LIBRARIES}\" \"${LIBRARY_DIRS}\" \"${LDFLAGS_OTHER}\"
COMMAND ${PYTHON_EXECUTABLE} ${sip_SIP_CONFIGURE} ${SIP_BUILD_DIR} ${SIP_FILE} ${sip_LIBRARY_DIR}
\"${INCLUDE_DIRS}\" \"${LIBRARIES}\" \"${LIBRARY_DIRS}\" \"${LDFLAGS_OTHER}\"
DEPENDS ${sip_SIP_CONFIGURE} ${SIP_FILE} ${sip_DEPENDS}
WORKING_DIRECTORY ${sip_SOURCE_DIR}
COMMENT "Running SIP generator for ${PROJECT_NAME} Python bindings..."
Expand Down

0 comments on commit 0af15ba

Please sign in to comment.