Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] convert rclcpp to chrono #80

Closed
wants to merge 1 commit into from

Conversation

wodtko
Copy link

@wodtko wodtko commented Sep 4, 2023

With a recent update of rclcpp::Rate the return value of .period() changed to rclcpp::Duration, thus, it must be converted to the std::chrono::duration used here.

ros2/rclcpp@bc43577 here are the respective changes in rclcpp

action-ros-ci-repos-supplemental: https://github.com/raw/ros2/ros2/rolling/ros2.repos

@wodtko wodtko requested a review from a team as a code owner September 4, 2023 15:51
@wodtko wodtko force-pushed the fix_chrono_rclcpp branch 2 times, most recently from 19974a0 to 1e669c4 Compare September 4, 2023 16:55
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for updating this.

CI is using a binary installation of Rolling, so that's why it's failing. To force it to build ROS 2 from source just for this PR, you could add the following line to the PR description, and then amend + force push your commit to make CI run again:

action-ros-ci-repos-supplemental: https://github.com/raw/ros2/ros2/rolling/ros2.repos

See https://github.com/ros-tooling/action-ros-ci#Interdependent-pull-requests-or-merge-requests.

Signed-off-by: Thomas Wodtko <thomas.wodtko@uni-ulm.de>
@christophebedard
Copy link
Member

It looks like this change (i.e., API break) was unintentional. It's being fixed in ros2/rclcpp#2301.

We won't need this PR, unless they actually deprecate this one and add a new Rate::period() method that returns a Duration. Until then, I'll close this. Thanks for contributing, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants