-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport Foxy] Update QD #63
Conversation
Codecov Report
@@ Coverage Diff @@
## foxy-devel #63 +/- ##
==============================================
- Coverage 25.40% 24.75% -0.65%
==============================================
Files 26 27 +1
Lines 807 820 +13
Branches 188 185 -3
==============================================
- Hits 205 203 -2
- Misses 435 454 +19
+ Partials 167 163 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Once the DCO passes this looks like it's ready (unless still in progress?). |
975ee44
to
ef3454e
Compare
I cherry-picked all the commits I don't know why this is happening |
Signed-off-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com> Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
ef3454e
to
619d39d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the fixed foxy-devel
links.
QUALITY_DECLARATION.md
Outdated
|
||
The `rcl` package supports implementation of language specific ROS Client Libraries. | ||
|
||
It is **Quality Level 3**, see its [Quality Declaration document](https://github.com/ros2/rcl/blob/foxy-devel/rcl/QUALITY_DECLARATION.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some (most?) of these branches should be foxy
instead of foxy-devel
.
Signed-off-by: ahcorde <ahcorde@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some dependencies can be updated
QUALITY_DECLARATION.md
Outdated
|
||
The `std_msgs` package provides many basic message types. | ||
|
||
It is **Quality Level 3**, see its [Quality Declaration document](https://github.com/ros2/common_interfaces/blob/foxy/std_msgs/QUALITY_DECLARATION.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is **Quality Level 3**, see its [Quality Declaration document](https://github.com/ros2/common_interfaces/blob/foxy/std_msgs/QUALITY_DECLARATION.md). | |
It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/common_interfaces/blob/foxy/std_msgs/QUALITY_DECLARATION.md). |
Signed-off-by: ahcorde <ahcorde@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this package can go straight to level 2, see the suggestions on ros2/rcl#843
@dabonnie , would you be able to merge this? Thanks! |
No description provided.