Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stereo_image_proc: consistent image_transport #903

Merged

Conversation

mikeferguson
Copy link
Member

  • make image_transport work
  • make remap work as expected with image_transport
  • make subscribers lazy

* make image_transport work
* make remap work as expected with image_transport
* make subscribers lazy
@mikeferguson
Copy link
Member Author

Testing notes:

  • Can remap output properly (--ros-args -r points2:=test)
  • Can remap individual camera topics:
    • -r left/image_raw:=test/image_raw remaps both left/image_raw and left/camera_info as expected
    • When also adding -p image_transport:=compressed we get the expected test/image_raw/compressed and test/camera_info
  • Can remap camera_info topic - but it's slightly more complex, since you need to remap the remapped topic (I see no way to cleanly remap "left/camera_info" while allowing camera_info to automatically remap properly for when "left/image_raw" has been changed. This isn't a common use case, and is kind of outside the expected standard, so we will simply document it)
  • Cannot remap just "left" and "right" - has to be "left/image_raw" - this is a bit different from ROS 1, but I think it is just how ROS 2 does lower level name spacing

@mikeferguson mikeferguson mentioned this pull request Jan 19, 2024
23 tasks
@mikeferguson mikeferguson merged commit 3dbd2b4 into ros-perception:rolling Jan 19, 2024
3 checks passed
@mikeferguson mikeferguson deleted the stereo_image_transport branch January 19, 2024 22:50
Kotochleb pushed a commit to Kotochleb/image_pipeline that referenced this pull request May 27, 2024
* make image_transport work
* make remap work as expected with image_transport
* make subscribers lazy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants