-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image_publisher_node not read camera_info_url on initialization #965
Comments
I'm not sure why there is a "return result" in any of those cases - I would think we should iterate through all the parameter settings by completing the for loop (and then there is a return after the reconfigure callback is called). I think we should actually remove the lines entirely (not change to a break). |
@mikeferguson this is precisely what caused my confusion and said lack of said confidence in making changes. If you think removing the |
…on startup (#983) As described in #965 camera info is not loaded from the file on node initialization, but only when the parameter is reloaded. This PR resolves this issue and should be straightforward to port it to `Humble`, `Iron` and `Jazzy`. (cherry picked from commit 847920b) # Conflicts: # image_publisher/src/image_publisher.cpp
…on startup (#983) As described in #965 camera info is not loaded from the file on node initialization, but only when the parameter is reloaded. This PR resolves this issue and should be straightforward to port it to `Humble`, `Iron` and `Jazzy`. (cherry picked from commit 847920b) # Conflicts: # image_publisher/src/image_publisher.cpp
…on startup (#983) As described in #965 camera info is not loaded from the file on node initialization, but only when the parameter is reloaded. This PR resolves this issue and should be straightforward to port it to `Humble`, `Iron` and `Jazzy`. (cherry picked from commit 847920b) # Conflicts: # image_publisher/src/image_publisher.cpp
Looks like fix is merged to Rolling, backports in progress |
…n startup (backport #983) (#996) As described in #965 camera info is not loaded from the file on node initialization, but only when the parameter is reloaded. This PR resolves this issue and should be straightforward to port it to `Humble`, `Iron` and `Jazzy`.<hr>This is an automatic backport of pull request #983 done by [Mergify](https://mergify.com). --------- Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com> Co-authored-by: Michael Ferguson <mfergs7@gmail.com>
…startup (backport #983) (#997) As described in #965 camera info is not loaded from the file on node initialization, but only when the parameter is reloaded. This PR resolves this issue and should be straightforward to port it to `Humble`, `Iron` and `Jazzy`.<hr>This is an automatic backport of pull request #983 done by [Mergify](https://mergify.com). --------- Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com> Co-authored-by: Michael Ferguson <mfergs7@gmail.com>
… startup (backport #983) (#995) As described in #965 camera info is not loaded from the file on node initialization, but only when the parameter is reloaded. This PR resolves this issue and should be straightforward to port it to `Humble`, `Iron` and `Jazzy`.<hr>This is an automatic backport of pull request #983 done by [Mergify](https://mergify.com). Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
As in the title,
image_publisher_node
doesn't account forcamera_info_url
on the initialization when launched as a standalone node on Humble. For some reason, it skips reading it. When the same parameter is changed dynamically after the node started, everything works just fine.The simplest walk-round I found was to change
return result
withbreak
in thepram_change_callback
like so:Yet, I feel like there should be a better solution to this, and I do not feel confident enough with the original implementation to submit a good enough bugfix PR.
The text was updated successfully, but these errors were encountered: