Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing non-existing attribute in SetCameraInfo response handling #1032

Closed
ugol-1 opened this issue Sep 15, 2024 · 0 comments · Fixed by #1033
Closed

Accessing non-existing attribute in SetCameraInfo response handling #1032

ugol-1 opened this issue Sep 15, 2024 · 0 comments · Fixed by #1033

Comments

@ugol-1
Copy link
Contributor

ugol-1 commented Sep 15, 2024

When the SetCameraInfo service call fails, cameracalibrator prints:

Traceback (most recent call last):
  File "/opt/ros/jazzy/lib/python3.12/site-packages/camera_calibration/camera_calibrator.py", line 304, in on_mouse
    if self.do_upload():
       ^^^^^^^^^^^^^^^^
  File "/opt/ros/jazzy/lib/python3.12/site-packages/camera_calibration/camera_calibrator.py", line 217, in do_upload
    rv = self.check_set_camera_info(response)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/ros/jazzy/lib/python3.12/site-packages/camera_calibration/camera_calibrator.py", line 199, in check_set_camera_info
    print("Attempt to set camera info failed: " + response.result() if response.result() is not None else "Not available")
                                                                       ^^^^^^^^^^^^^^^
AttributeError: 'SetCameraInfo_Response' object has no attribute 'result'

It should print the message from the SetCameraInfo response though.

ugol-1 pushed a commit to potatomatic/image_pipeline that referenced this issue Sep 15, 2024
@ugol-1 ugol-1 mentioned this issue Sep 15, 2024
ugol-1 pushed a commit to potatomatic/image_pipeline that referenced this issue Sep 17, 2024
ugol-1 pushed a commit to potatomatic/image_pipeline that referenced this issue Sep 20, 2024
ugol-1 pushed a commit to potatomatic/image_pipeline that referenced this issue Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant