Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create new package nav2_composition #2546

Closed
wants to merge 1 commit into from

Conversation

gezp
Copy link
Contributor

@gezp gezp commented Sep 6, 2021

Signed-off-by: zhenpeng ge zhenpeng.ge@qq.com


Basic Info

Info Please fill out this column
Ticket(s) this addresses (tickets: #2147)
Primary OS tested on (Ubuntu20.04, ROS 2 Galactic from binaries)
Robotic platform tested on (gazebo simulation of turtlebot3)

Description of contribution in a few bullet points

create a composition-based bringup package for Nav2, in other word, compose all Nav2 nodes in a single process instead of launching these nodes separately, which is useful for embedded systems users that need to make optimizations due to harsh resource constraints.

  • create multiple nodes in a single main() (manual composition).
  • create a bunch of single threaded executors to spin these nodes.

you can find some details about performance test(cpu and memory usage) here


Future work that may be required in bullet points

try to enable intra-process comms until it's stable in ROS2, which are still kind of under development currently, you can find more detials:

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Signed-off-by: zhenpeng ge <zhenpeng.ge@qq.com>
@gezp
Copy link
Contributor Author

gezp commented Sep 8, 2021

It provides a composition-based bringup method, which could replace launching Nav2 nodes separately in package nav2_bringup, so it's not necessary to create a new package nav2_composition , just put it in package nav2_bringup.

The PR should be closed and new PR #2555 is created.

@gezp gezp closed this Sep 8, 2021
@gezp gezp deleted the nav2_composition branch January 27, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant