Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Galactic Geochelone to REP 2000 #291

Merged
merged 14 commits into from
Jan 7, 2021
Merged

Add Galactic Geochelone to REP 2000 #291

merged 14 commits into from
Jan 7, 2021

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Nov 20, 2020

Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay self-assigned this Nov 20, 2020
rep-2000.rst Outdated Show resolved Hide resolved
Signed-off-by: Scott K Logan <logans@cottsay.net>
rep-2000.rst Outdated Show resolved Hide resolved
@dejanpan
Copy link

@cottsay @clalancette I provided a detailed feedback on what switching to C++17 currently means in the automotive industry: eclipse-iceoryx/iceoryx#220 (comment).

the conclusion is in the last sentence of above comment. I suggest the following: proceed with the switch to C++17 and I'll in the next weeks inquire a) about the willingness of our (automotive) customers to switch to C++17 and b) when Adaptive Autosar Coding Guidelines for C++17 will be available.

@clalancette
Copy link
Contributor

@dejanpan Thanks for the detailed feedback on the switch to C++17. That really helps inform the decision here.

Given your feedback, and the fact that we have heard no objections to C++17, we'll go forward with that for now. If it turns out that this is a huge problem, let us know as soon as possible and we'll see what we can do about it.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to change in here.

rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-12-17/18182/1

@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/macos-support-in-ros-2-galactic-and-beyond/17891/14

Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
Follow-up to 33f3413

Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay marked this pull request as ready for review January 6, 2021 00:58
Follow-up to f2b5692

Signed-off-by: Scott K Logan <logans@cottsay.net>
Follow-up to 6bac4b9

Signed-off-by: Scott K Logan <logans@cottsay.net>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got one nit and one question inline, but otherwise this looks good to me.

rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
cottsay and others added 3 commits January 6, 2021 14:26
Signed-off-by: Scott K Logan <logans@cottsay.net>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Scott K Logan <logans@cottsay.net>
The system-provided Python 3 interpreter for RHEL 7 and 8 is version
3.6, so relaxing this minimum requirement to include those platforms.
We've been running CI on CentOS 7 for many months, and there don't seem
to be any places where we're taking advantage of any features that
require Python 3.7.

Signed-off-by: Scott K Logan <logans@cottsay.net>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to go ahead and approve, since I think that what we have here is a good start. We can make more updates later. You may want to still consider @jacobperron's comments before merging.

@cottsay
Copy link
Member Author

cottsay commented Jan 6, 2021

You may want to still consider @jacobperron's comments before merging.

I'm going to make those changes before merging. The chef-based deployment makes it much easier to do than it used to be.

.. [9] Foxy ROS 2 Repos File
(https://github.com/ros2/ros2/blob/foxy/ros2.repos)
.. [10] Galactic ROS 2 Repos File
(https://github.com/ros2/ros2/blob/master/ros2.repos)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this link should be updated after we branch (circa April).

These are the version numbers present on our CI machines at this time,
so it's what we've been developing and testing against.

Signed-off-by: Scott K Logan <logans@cottsay.net>
rep-2000.rst Outdated Show resolved Hide resolved
Signed-off-by: Scott K Logan <logans@cottsay.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants