Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a helper class for defining mappers for recursive data structures #15

Closed
roookeee opened this issue Jun 12, 2019 · 4 comments
Closed
Assignees
Milestone

Comments

@roookeee
Copy link
Owner

roookeee commented Jun 12, 2019

I reconsidered adding this functionality to datus as there are quite a few scenarios wherin simple data structures are recursively included in themselfs (parent child relations like categories or products containing more subproduct variants).

There is an utility class outlined in https://github.com/roookeee/datus/blob/master/USAGE.md#advanced-usage--faq to fix this problem. Implementing the given class once (+ unit tests) is far superior to letting users handle it themselves.

Let's add it :)

@roookeee roookeee added enhancement New feature or request semver-minor labels Jun 12, 2019
@roookeee roookeee added this to the 1.2.0 milestone Jun 12, 2019
@roookeee roookeee self-assigned this Jun 12, 2019
@roookeee
Copy link
Owner Author

roookeee commented Jun 13, 2019

Initial implementation done in branch issue-15. Will have to review the changes and documentation before merging into develop (1.2.0-SNAPSHOT).

@roookeee
Copy link
Owner Author

roookeee commented Jun 13, 2019

As #16 is still open: should I apply PECS here?

@roookeee
Copy link
Owner Author

roookeee commented Jun 20, 2019

PECS was added in branch issue-15

@roookeee
Copy link
Owner Author

Merged into develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant