Clear fast boot rendered head on browser boot #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split initializers into fastboot & browser flavors. Use placeholder meta tags for marking extent of head.hbs content.
| .nextUntil('meta[name="ember-cli-head-end"] ~') | ||
| .addBack() | ||
| .remove(); | ||
| const container = instance.lookup ? instance : instance.container; |
There was a problem hiding this comment.
Should be able to remove this conditional, fastboot only supports ember 2.3.0+ so instance.lookup should always be present.
|
This requires a shared package to ensure that fastboot version doesn't run when it ember-cli-fastboot is not present (since this addon still supports that world). @tomdale this is he scenario that I was explaining on the fastboot/browser initializer stripping PR. |
|
See ember-fastboot/ember-cli-fastboot#110 (comment) for details on filtering the initializers. |
|
Is this good to go? |
|
@tomdale haven't tested out the filter module as much as I plan to yet, but I should be able to cut a new release of this addon today. |
ronco
added a commit
that referenced
this pull request
Mar 1, 2016
Clear fast boot rendered head on browser boot
|
@tomdale just published as 0.0.4 |
|
You're the hero Gotham needs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split initializers into fastboot & browser flavors.
Use placeholder meta tags for marking extent of head.hbs content.