Fastboot compatibility #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ); | ||
| component.appendTo('head'); | ||
| const componentFactory = | ||
| instance.__container__.lookupFactory('component:head-content'); |
There was a problem hiding this comment.
use instance._lookupFactory instead
|
Left a few nit-picks, but looks good otherwise. |
|
Thanks! It'll be a couple days till I can work on this again, but I'll try
|
ronco
force-pushed
the
feature/fastboot-compat
branch
3 times, most recently
from
01854de
to
344504f
Compare
ronco
force-pushed
the
feature/fastboot-compat
branch
from
344504f
to
673de64
Compare
If FastBoot isn't found in the sandbox go ahead and straightup lookup the component, this keeps things compatible in older ember versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually construct head component (for fastboot).
Instantiating the component automatically through the container throws an exception under fastboot because a new DomHelper is created which relies upon
document.For full functionality we will also need an index.html placeholder, and updates to ember-fastboot-server to serialize the head component.