Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Allow named entrypoints #329

Merged
merged 2 commits into from
Aug 9, 2018
Merged

Allow named entrypoints #329

merged 2 commits into from
Aug 9, 2018

Conversation

mister-what
Copy link

With experimentalCodeSplitting flag turned on, rollup allows multiple entrypoints in array form (already supported by this plugin) and as an object (see here: https://rollupjs.org/guide/en#core-functionality - subsection input) representing named entrypoints (currently not supported by this plugin).
Since we have a high demand on this feature on our project, I'd like to contribute back the necessary changes to make objects as multiple entrypoints work with this plugin.

I added a test for this extra feature and made sure that all other tests are still working as expected.
To make the tests work with this form of entrypoints I had to update your devDependency of Rollup to 0.63.2 (latest at the current time).

Regards,
Jonas

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Sorry this has been waiting for some time. As this includes a test but basically solves the same issue as #322, I will give this one preference.

@lukastaegert lukastaegert merged commit 93f4ce4 into rollup:master Aug 9, 2018
@lukastaegert lukastaegert mentioned this pull request Aug 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants