Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fluentd a suggest requirement rather than mandatory #229

Closed
cordoval opened this issue Jul 17, 2017 · 5 comments
Closed

Make fluentd a suggest requirement rather than mandatory #229

cordoval opened this issue Jul 17, 2017 · 5 comments
Assignees
@ArturMoczulski

Comments

@cordoval
Copy link
Contributor

No description provided.

@cordoval cordoval changed the title make fluentd a suggest requirement rather than mandatory Make fluentd a suggest requirement rather than mandatory Jul 17, 2017
@ArturMoczulski ArturMoczulski self-assigned this Jul 19, 2017
@ArturMoczulski
Copy link
Contributor

What's the reasoning behind making this change? @rokob @coryvirok what do you guys think?

@brianr
Copy link
Member

brianr commented Jul 19, 2017

@cordoval's suggestion sounds like the right thing to do to me. Most people using rollbar-php aren't going to use the fluent connector, so there's no reason it should be a required dependency.

@cordoval
Copy link
Contributor Author

The way this works also is i use kubernetes and I have to have the freedom to just channel the exceptions however we wanted. Fluentd is not bad, just not a must have.

@ArturMoczulski
Copy link
Contributor

Ready for review in PR #230

@cordoval
Copy link
Contributor Author

closing this as #230 is LGTM too 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArturMoczulski ArturMoczulski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brianr @cordoval @ArturMoczulski