Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatReq: Close windows in right sidebar #56

Open
RenHoekNL opened this issue Feb 21, 2023 · 5 comments
Open

FeatReq: Close windows in right sidebar #56

RenHoekNL opened this issue Feb 21, 2023 · 5 comments

Comments

@RenHoekNL
Copy link

The right sidebar has a number of windows, however my screen is a little small on my laptop.

When I step through my program I want to keep an eye on the variables, but I can't see those without scrolling the sidebar down a bit.

Then I step, and the sidebar window is reset again to the top. Again, I can't see my variables anymore.

Fixes:

  • Allow me to close windows I don't need, e.g. Disassembly
  • Keep the windows position where it is when stepping

Ideally both these changes are put in. Thanks in advance.

@rohanrhu rohanrhu added feature request bug Something isn't working labels Feb 21, 2023
@rohanrhu
Copy link
Owner

rohanrhu commented Feb 21, 2023

Hi @RenHoekNL thank you for your feedback.

GF got a feature about that it must keep your current scroll position on each step.

It must act like this:

GDBFrontend.Right.Panel.Scroll.Behavior.on.Scroll.mp4

Seems like it is not working for you 🙁

What is your browser? If it is not Chrome can you try it on Chrome?

@RenHoekNL
Copy link
Author

Can confirm it 'works' in Chrome. I'm using Firefox 110.0 (64-bit).

It does jump the sidebar around in Chrome as well, at least it stick to the part I was using. It doesn't just stay where I was though and when I'm deep in structs I still have to scroll back.

It could use some TLC.

@rohanrhu
Copy link
Owner

rohanrhu commented Feb 22, 2023

Can confirm it 'works' in Chrome. I'm using Firefox 110.0 (64-bit).

Oh good... Just use Chrome till I fix it for the other browser.

It does jump the sidebar around in Chrome as well, at least it stick to the part I was using. It doesn't just stay where I was though and when I'm deep in structs I still have to scroll back.

It expands all previously opened structs right? I remember variables view has its own scrollable too I'm not sure if it has the same feature as the whole inspector side but I will add the same feature for that too.

@sgbeal
Copy link

sgbeal commented Feb 21, 2024

Please consider this another request for the ability to remove unneeded right-side widgets. i literally never need the Registers window and it takes up a LOT of space which i'd much rather have for the Variables. i can use the browser's Inspector to remove the Registers widget, but then the Variables has a fixed max size so won't grow to fill that space. i can get around that by removing the max-height from div.VariablesExplorer_content it and adding resize:vertical to that element, but this is a tedious workaround.

@rohanrhu
Copy link
Owner

Please consider this another request for the ability to remove unneeded right-side widgets. i literally never need the Registers window and it takes up a LOT of space which i'd much rather have for the Variables. i can use the browser's Inspector to remove the Registers widget, but then the Variables has a fixed max size so won't grow to fill that space. i can get around that by removing the max-height from div.VariablesExplorer_content it and adding resize:vertical to that element, but this is a tedious workaround.

Hi @sgbeal my brain is really burning because of working and some other things but I'll find a time for these things soon.

I'll make right bar sections optionally enabled/disabled, I'll also make right bar's variables explorer dynamic-sized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants