Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up /opt directory in geospatial #571

Closed
rdenham opened this issue Dec 6, 2022 · 4 comments · Fixed by #576 or #581
Closed

Clean up /opt directory in geospatial #571

rdenham opened this issue Dec 6, 2022 · 4 comments · Fixed by #576 or #581
Labels
bug Something isn't working good first issue Good for newcomers pre-built images Related to pre-built images rocker scripts Related to rocker scripts

Comments

@rdenham
Copy link
Contributor

rdenham commented Dec 6, 2022

The rocker/geospatial:4.2.2 image seems to have a fair bit of leftover build files in /opt/grib2,

singularity exec docker://rocker/geospatial:4.2.2 du -sh /opt/grib2
INFO:    Using cached SIF image
179M    /opt/grib2
singularity exec docker://rocker/geospatial:4.2.2 ls -l  /opt/grib2/|grep .gz
INFO:    Using cached SIF image
-rw-r--r--  1 root root  8406357 Sep 26  2013 gctpc20a.tgz
-rw-r--r--  1 root root  1166082 Jul  6  2018 jasper-1.900.1-14ubuntu3.2.debian.tgz
-rw-r--r--  1 root root  3119620 Oct 19  2017 libaec-1.0.2.tar.gz
-rw-r--r--  1 root root  1118350 Mar 29  2022 libpng-1.2.59.tar.gz
-rw-r--r--  1 root root 11572512 Jun 28  2012 netcdf-3.6.3.tar.gz
-rw-r--r--  1 root root  2233229 Aug 23  2021 openjpeg-2.4.0.tar.gz
-rw-r--r--  1 root root   785279 Jun 22  2012 proj-4.8.0.tar.gz
-rw-r--r--  1 root root  1490071 Mar 29  2022 zlib-1.2.12.tar.gz

I don't think these are needed after the build, so perhaps they could be cleaned up. Looks like they are installed via
scripts/install_wgrib2.sh

Perhaps there could be a bit of clean up in that script to remove unnecessary build files.

@cboettig
Copy link
Member

cboettig commented Dec 7, 2022

indeed, good catch. A PR would be welcome!

(it may also be worth deprecating that script entirely, I've found that recent GDAL versions from OSGEO handle grib files just fine already...)

@eitsupi eitsupi added bug Something isn't working good first issue Good for newcomers rocker scripts Related to rocker scripts pre-built images Related to pre-built images labels Dec 7, 2022
@rdenham
Copy link
Contributor Author

rdenham commented Dec 8, 2022

Thanks @cboettig I'll create a PR and update this issue

@rdenham
Copy link
Contributor Author

rdenham commented Dec 10, 2022

See this PR #576

I tested reading of grib file using gdalinfo, and also terra::rast and seems fine.

There may be others who rely on wgrib but I wasn't sure how to identify those to check if they would be affected.

@eitsupi
Copy link
Member

eitsupi commented Dec 17, 2022

Reopen as it has not been resolved for focal based images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers pre-built images Related to pre-built images rocker scripts Related to rocker scripts
Projects
None yet
3 participants