Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Matlab high-level wrappers #1199

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Update Matlab high-level wrappers #1199

merged 4 commits into from
Aug 5, 2024

Conversation

gabrielenava
Copy link
Contributor

Hello @traversaro, I have realized that in the end we never merged the optimization of the iDynTree high level Matlab wrappers in master. Following the old PR #744 I have:

  • rebased the modifications done back in time on the current master;
  • fixed a bug related to a missing initialization of variables in loadReducedModel.m:
  • formatted all files using the smart-indent functionality of MATLAB (ctrl+i) so that they all have the same style
  • tested the code with iRonCub Matlab-based controllers and seems they work fine.

Besides the alignment of formatting style and the removal of trailing spaces, the main change is that every time the iDynTree wrappers are called, instead of creating a new object of the corresponding iDynTree class, updating it, then returning its content to matlab, they now directly update an already existing object which is created when loadReducedModel.m is called. This can save some computation time especially if a wrapper is called many times in the code. The change should not require any update of existing applications that use the wrappers.

We may try again to merge this changes in master! Let me know what you think about it.

@traversaro
Copy link
Member

Thanks!

@traversaro traversaro merged commit 73cc11c into master Aug 5, 2024
37 checks passed
@traversaro traversaro deleted the upd_matlab_wrappers branch August 5, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants