Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't convert complex to float #2

Open
chauvinSimon opened this issue Mar 26, 2018 · 1 comment
Open

can't convert complex to float #2

chauvinSimon opened this issue Mar 26, 2018 · 1 comment

Comments

@chauvinSimon
Copy link

Thank you for this great code!

Just one question regarding the line 16 of prioritized_memory.py:
Should not the absolute value of the TD-error be taken in return (error + self.e) ** self.a ?

This is what is done in the original paper.
In addition, if not using abs(), I get the error can't convert complex to float due to (error + self.e) being negative.

@being-aerys
Copy link

You are correct in saying that the priority value = absolute td error. However, I think the passed error in return (error + self.e) ** self.a ? is already an absolute value. Or at least that is what u are supposed to do if not already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants