Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object field errors should render above fields, not under the fieldset #196

Closed
n1k0 opened this issue May 9, 2016 · 3 comments
Closed

Object field errors should render above fields, not under the fieldset #196

n1k0 opened this issue May 9, 2016 · 3 comments
Labels
question

Comments

@n1k0
Copy link
Collaborator

n1k0 commented May 9, 2016 •
edited
Loading

Spawned from #163
@n1k0 n1k0 added the question label May 9, 2016
@n1k0 n1k0 changed the title Object field errors should rendered above fields, not under the fieldset Object field errors should render above fields, not under the fieldset May 10, 2016
@n1k0 n1k0 mentioned this issue Jul 18, 2016
Closed
@n1k0
Copy link
Collaborator Author

n1k0 commented Aug 19, 2016

#304 has landed but I now realize we don't have enough props information passed to the field template component to distinguish which type of field we're dealing with. We should at least pass the schema field type so we can test for it.

@n1k0 n1k0 mentioned this issue Aug 19, 2016
Merged
@n1k0 n1k0 mentioned this issue Oct 20, 2016
Closed
1 task
@epicfaace
Copy link
Member

@n1k0 is this still a problem?

@epicfaace
Copy link
Member

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@n1k0 @epicfaace