Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for token directly, auth broken #11

Open
jneidel opened this issue Jul 17, 2018 · 0 comments
Open

Ask for token directly, auth broken #11

jneidel opened this issue Jul 17, 2018 · 0 comments

Comments

@jneidel
Copy link

jneidel commented Jul 17, 2018

Why don't you ask the user to create a token for authentication (like every other github-cli)? At least give me the choice to input it directly.

That way it's much easier for the application (less points of failure) and it's much more secure for the user (tokens are easily revokable, you don't get their password).

And your authentication process is broken for me (both token as password and password):

$ node -v
v10.5.0
$npm -v
6.2.0
$ starring
Your GitHub username: jneidel                                                                                                                          
Your GitHub password: ✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔                                                                                         
                                                                                                                                                       
(node:25425) TimeoutOverflowWarning: 4294967296000 does not fit into a 32-bit signed integer.                                                          
Timer duration was truncated to 2147483647.                                                                                                            
(node:25425) TimeoutOverflowWarning: 4294967296000 does not fit into a 32-bit signed integer.                                                          
Timer duration was truncated to 2147483647.                                                                                                            
/home/jneidel/.bin/node-10.5.0/lib/node_modules/starring/dist/cli.js:134                                                                               
        var _ref3 = _asyncToGenerator(function* (err, { token }) {                                                                                     
                                                        ^                                                                                              
                                                                                                                                                       
TypeError: Cannot destructure property `token` of 'undefined' or 'null'.                                                                               
    at /home/jneidel/.bin/node-10.5.0/lib/node_modules/starring/dist/cli.js:134:42                                                                     
    at /home/jneidel/.bin/node-10.5.0/lib/node_modules/starring/dist/cli.js:63:68                                                                     
    at ghAuth (/home/jneidel/.bin/node-10.5.0/lib/node_modules/starring/dist/cli.js:153:16)                                                           
    at afterCreateAuth (/home/jneidel/.bin/node-10.5.0/lib/node_modules/starring/node_modules/ghauth/ghauth.js:155:16)                                
    at BufferList.afterCreateAuthResponse [as _callback] (/home/jneidel/.bin/node-10.5.0/lib/node_modules/starring/node_modules/ghauth/ghauth.js:42:14)
    at BufferList.end (/home/jneidel/.bin/node-10.5.0/lib/node_modules/starring/node_modules/bl/bl.js:98:10)                                          
    at DuplexWrapper.onend (/home/jneidel/.bin/node-10.5.0/lib/node_modules/starring/node_modules/duplexer2/node_modules/readable-stream/lib/_stream_readable.js:537:10)
    at Object.onceWrapper (events.js:273:13)
    at DuplexWrapper.emit (events.js:187:15)
    at /home/jneidel/.bin/node-10.5.0/lib/node_modules/starring/node_modules/duplexer2/node_modules/readable-stream/lib/_stream_readable.js:934:16 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant