Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streaming: fix hash join degree table scan #6087

Closed
Tracked by #6103
skyzh opened this issue Oct 28, 2022 · 1 comment · Fixed by #6159
Closed
Tracked by #6103

streaming: fix hash join degree table scan #6087

skyzh opened this issue Oct 28, 2022 · 1 comment · Fixed by #6159

Comments

@skyzh
Copy link
Contributor

skyzh commented Oct 28, 2022

             let mut table_data = vec![];
             let mut degree_table_data = vec![];

             #[for_await]
             for x in table_iter {
                 table_data.push(x?);
             }

             #[for_await]
             for x in degree_table_iter {
                 degree_table_data.push(x?);
             }

Now we fetch ALL the data before start processing, instead of fetch-while-processing.

Part of #5977, can be fixed after the compiler bug is fixed.

@skyzh
Copy link
Contributor Author

skyzh commented Nov 26, 2022

Can be fixed by bumping the toolchain as the upstream PR has been merged. Anyone interested in this issue can work on it.

@skyzh skyzh removed their assignment Nov 26, 2022
@mergify mergify bot closed this as completed in #6159 Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant