Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: e2e coverage for Rust #32

Closed
skyzh opened this issue Jan 10, 2022 · 3 comments
Closed

ci: e2e coverage for Rust #32

skyzh opened this issue Jan 10, 2022 · 3 comments
Labels
no-issue-activity

Comments

@skyzh
Copy link
Contributor

skyzh commented Jan 10, 2022

Currently, e2e doesn't take Rust codebase into account when calculating coverage. In the future, we should do this.
@liurenjie1024
Copy link
Contributor

Is it really reasonable to include e2e test when calculating coverage?

@skyzh
Copy link
Contributor Author

skyzh commented Jan 10, 2022

Our java frontend uses e2e for coverage. When we have a Rust frontend, we also need this.

@skyzh skyzh transferred this issue from another repository Jan 29, 2022
@skyzh
Copy link
Contributor Author

skyzh commented Jun 6, 2022

cargo llvm provides an easy way to run external tests:

https://github.com/taiki-e/cargo-llvm-cov#get-coverage-of-external-tests

We can use this to generate e2e test coverage.

@skyzh skyzh closed this as completed Nov 26, 2022
@xxchan xxchan mentioned this issue Feb 16, 2023
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
no-issue-activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@liurenjie1024 @skyzh @neverchanje