Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document parameter check for CDC connector #661

Closed
hengm3467 opened this issue Mar 20, 2023 · 0 comments · Fixed by #669
Closed

Document parameter check for CDC connector #661

hengm3467 opened this issue Mar 20, 2023 · 0 comments · Fixed by #669
Assignees
@emile-00
Labels
documentation Improvements or additions to documentation
Milestone
v0.18.0

Comments

@hengm3467
Copy link
Collaborator

Related code PR

risingwavelabs/risingwave#8450

Which part(s) of the docs might be affected or should be updated? And how?

https://www.risingwave.dev/docs/current/ingest-from-postgres-cdc/#with-parameters

Changes to be made:
Make parameter "schema" optional. Default value should be "public".
Make parameter "slot.name" optional. Generate a random slot name by default. (See also Materialize's doc: https://materialize.com/docs/sql/create-source/postgres/#creating-a-source)

Reference

No response
@hengm3467 hengm3467 added the documentation Improvements or additions to documentation label Mar 20, 2023
@hengm3467 hengm3467 added this to the v0.1.18 milestone Mar 20, 2023
@emile-00 emile-00 mentioned this issue Mar 20, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emile-00 emile-00

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging a pull request may close this issue.

Document PG CDC parameter check risingwavelabs/risingwave-docs
2 participants
@hengm3467 @emile-00