qmmp-plugin-youtube needs to be updated to qmmp's API 1.3

[4re]

Hi rigon, when I try to compile this plugin against qmmp-1.3.4 I get this error:

cd youtubeui/ && ( test -e Makefile || /usr/lib64/qt5/bin/qmake -o Makefile /tmp/portage/media-plugins/qmmp-plugin-youtube-0.3.2/work/qmmp-plugin-youtube-0.3.2/youtubeui/youtubeui.pro 'QMAKE_AR=x86_64-pc-linux-gnu-ar cqs' QMAKE_CC=x86_64-pc-linux-gnu-gcc QMAKE_LINK_C=x86_64-pc-linux-gnu-gcc QMAKE_LINK_C_SHLIB=x86_64-pc-linux-gnu-gcc QMAKE_CXX=x86_64-pc-linux-gnu-g++ QMAKE_LINK=x86_64-pc-linux-gnu-g++ QMAKE_LINK_SHLIB=x86_64-pc-linux-gnu-g++ QMAKE_OBJCOPY=x86_64-pc-linux-gnu-objcopy QMAKE_RANLIB= QMAKE_STRIP= 'QMAKE_CFLAGS=-O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=4 -fuse-linker-plugin -march=native -pipe -falign-functions=32 -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu' QMAKE_CFLAGS_RELEASE= QMAKE_CFLAGS_DEBUG= 'QMAKE_CXXFLAGS=-O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=4 -fuse-linker-plugin -march=native -pipe -falign-functions=32 -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu' QMAKE_CXXFLAGS_RELEASE= QMAKE_CXXFLAGS_DEBUG= 'QMAKE_LFLAGS=-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=4 -fuse-linker-plugin -march=native -pipe -falign-functions=32' QMAKE_LFLAGS_RELEASE= QMAKE_LFLAGS_DEBUG= ) && make -f Makefile 
make[1]: Entering directory '/tmp/portage/media-plugins/qmmp-plugin-youtube-0.3.2/work/qmmp-plugin-youtube-0.3.2/youtube'
x86_64-pc-linux-gnu-g++ -c -O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=4 -fuse-linker-plugin -march=native -pipe -falign-functions=32 -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -Wall -W -D_REENTRANT -fPIC -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -isystem /usr/include/python3.6m -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtCore -I. -isystem /usr/include/libdrm -I/usr/lib64/qt5/mkspecs/linux-g++ -o youtubefactory.o youtubefactory.cpp
x86_64-pc-linux-gnu-g++ -c -O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=4 -fuse-linker-plugin -march=native -pipe -falign-functions=32 -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -Wall -W -D_REENTRANT -fPIC -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -isystem /usr/include/python3.6m -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtCore -I. -isystem /usr/include/libdrm -I/usr/lib64/qt5/mkspecs/linux-g++ -o youtubeinputsource.o youtubeinputsource.cpp
x86_64-pc-linux-gnu-g++ -c -O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=4 -fuse-linker-plugin -march=native -pipe -falign-functions=32 -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -Wall -W -D_REENTRANT -fPIC -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -isystem /usr/include/python3.6m -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtCore -I. -isystem /usr/include/libdrm -I/usr/lib64/qt5/mkspecs/linux-g++ -o youtubestreamreader.o youtubestreamreader.cpp
make[1]: Entering directory '/tmp/portage/media-plugins/qmmp-plugin-youtube-0.3.2/work/qmmp-plugin-youtube-0.3.2/youtubeui'
/usr/lib64/qt5/bin/uic youtubewindow.ui -o ui_youtubewindow.h
/usr/lib64/qt5/bin/uic youtubepreferences.ui -o ui_youtubepreferences.h
x86_64-pc-linux-gnu-g++ -c -O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=4 -fuse-linker-plugin -march=native -pipe -falign-functions=32 -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -Wall -W -D_REENTRANT -fPIC -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtCore -I. -isystem /usr/include/libdrm -I. -I/usr/lib64/qt5/mkspecs/linux-g++ -o youtubewindow.o youtubewindow.cpp
youtubewindow.cpp:41:10: fatal error: qmmp/fileinfo.h: No such file or directory
   41 | #include <qmmp/fileinfo.h>
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [Makefile:1062: youtubewindow.o] Error 1
make[1]: Leaving directory '/tmp/portage/media-plugins/qmmp-plugin-youtube-0.3.2/work/qmmp-plugin-youtube-0.3.2/youtubeui'
make: *** [Makefile:73: sub-youtubeui-make_first] Error 2
make: *** Waiting for unfinished jobs....
x86_64-pc-linux-gnu-g++ -c -O3 -fgraphite-identity -floop-nest-optimize -fdevirtualize-at-ltrans -fipa-pta -fno-semantic-interposition -flto=4 -fuse-linker-plugin -march=native -pipe -falign-functions=32 -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -Wall -W -D_REENTRANT -fPIC -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -isystem /usr/include/python3.6m -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtCore -I. -isystem /usr/include/libdrm -I/usr/lib64/qt5/mkspecs/linux-g++ -o youtubedl.o youtubedl.cpp
In file included from youtubefactory.cpp:32:
youtubefactory.h:45:33: error: invalid covariant return type for ‘virtual const InputSourceProperties YoutubeFactory::properties() const’
   45 |     const InputSourceProperties properties() const;
      |                                 ^~~~~~~~~~
In file included from youtubefactory.h:29,
                 from youtubefactory.cpp:32:
/usr/include/qmmp/inputsourcefactory.h:62:35: note: overridden function is ‘virtual InputSourceProperties InputSourceFactory::properties() const’
   62 |     virtual InputSourceProperties properties() const = 0;
      |                                   ^~~~~~~~~~
youtubeinputsource.cpp: In member function ‘void YoutubeInputSource::fetchVideoMetaDataComplete(QHash<QString, QString>)’:
youtubeinputsource.cpp:57:27: error: ‘URL’ is not a member of ‘Qmmp’
   57 |     metaData.insert(Qmmp::URL, this->url());
      |                           ^~~
youtubeinputsource.cpp:57:38: error: ‘class YoutubeInputSource’ has no member named ‘url’
   57 |     metaData.insert(Qmmp::URL, this->url());
      |                                      ^~~
make[1]: *** [Makefile:1035: youtubefactory.o] Error 1
make[1]: *** Waiting for unfinished jobs....
youtubestreamreader.cpp: In member function ‘void YoutubeStreamReader::checkBuffer()’:
youtubestreamreader.cpp:388:35: error: ‘URL’ is not a member of ‘Qmmp’
  388 |             metaData.insert(Qmmp::URL, m_url);
      |                                   ^~~
youtubestreamreader.cpp: In member function ‘void YoutubeStreamReader::parseICYMetaData(char*, qint64)’:
youtubestreamreader.cpp:477:35: error: ‘URL’ is not a member of ‘Qmmp’
  477 |             metaData.insert(Qmmp::URL, m_url);
      |                                   ^~~
make[1]: *** [Makefile:1041: youtubeinputsource.o] Error 1
make[1]: *** [Makefile:1046: youtubestreamreader.o] Error 1
make[1]: Leaving directory '/tmp/portage/media-plugins/qmmp-plugin-youtube-0.3.2/work/qmmp-plugin-youtube-0.3.2/youtube'
make: *** [Makefile:48: sub-youtube-make_first] Error 2```

[pallebone]

Does anyone know how to resolve this issue?