Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored helpers, classes and namespaces for clarity #85

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Conversation

ricardoboss
Copy link
Owner

Things done in this branch:

  • Moved all classes from StepLang.Parsing.Statements to StepLang.Statements
  • Moved all classes from StepLang.Parsing.Expressions to StepLang.Expressions and all ExpressionResults to StepLang.Expressions.Results
  • Renamed ConstantExpression to LiteralExpression (because that's what it actually is)
  • Moved helpers for creating BinaryExpressions to the BinaryExpression class
  • Moved helpers for creating UnaryExpressions to the UnaryExpression class
  • Added explicit NotEquals helper to BinaryExpression (was a compound expression using Not and Equals which resulted in a UnaryExpression)
  • Removed the Expression.Constant helpers and replaced them with LiteralExpression.<type> calls
  • Removed return void from FunctionResult.VoidFunction so now it is just an empty function (implicitly returning void)
  • Renamed ToExpression helper to ToLiteralExpression in ExpressionResult

All in all these are some changes I had in mind for a long time.

@ricardoboss ricardoboss changed the title Refactored classes and namespaces for clarity Refactored helpers, classes and namespaces for clarity Sep 22, 2023
@ricardoboss ricardoboss merged commit 20cf447 into main Sep 22, 2023
9 checks passed
@ricardoboss ricardoboss deleted the refactors branch September 22, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant