Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jakarta Servlet API 5.0+ #451

Closed
ExtraCrafTX opened this issue Jan 20, 2021 · 5 comments
Closed

Jakarta Servlet API 5.0+ #451

ExtraCrafTX opened this issue Jan 20, 2021 · 5 comments

Comments

@ExtraCrafTX
Copy link

The servlet API is moving to the jakarta namespace from javax.
https://jakarta.ee/specifications/servlet/5.0/

Would be great to get a release for the new namespace.
@wilkinsona wilkinsona mentioned this issue Nov 16, 2021
Closed
@agebhar1 agebhar1 mentioned this issue Nov 25, 2021
Closed
@mhalbritter mhalbritter mentioned this issue Jun 29, 2022
Closed
@erikpetzold erikpetzold mentioned this issue Jan 6, 2023
Closed
@ftrossbach ftrossbach mentioned this issue Jan 6, 2023
Closed
@tadayosi tadayosi mentioned this issue Apr 15, 2023
Closed
@Croway Croway mentioned this issue Jun 23, 2023
Closed
@grgrzybek grgrzybek changed the title Jakarta Servlet API 5.0 Jakarta Servlet API 5.0+ Sep 12, 2023
@grgrzybek
Copy link
Contributor

grgrzybek commented Sep 12, 2023 •
edited
Loading

The discussion: #555

@grgrzybek grgrzybek mentioned this issue Sep 12, 2023
Closed
@tadayosi tadayosi mentioned this issue Sep 20, 2023
Closed
grgrzybek added a commit that referenced this issue Sep 20, 2023
@grgrzybek
[#451] Remove direct dependency on Servlet API from agent/jvm
b661267 
Instead of Jetty, we use now Undertow (core), which has fewer
dependencies and doesn't depend on Servlet API at all. At the same time
the version used for undertow-servlet library will use Servlet API 6 and
still be JDK11 compatible.

On the other hand, Jetty 12 is multi-servlet-API version, but requires
JDK17.
grgrzybek added a commit that referenced this issue Sep 20, 2023
@grgrzybek
[#451] Remove direct dependency on Servlet API and EasyMock from tool…
1f8973f 
…s/test-util

HttpTestUtil.java was moved (for now) to server/core, but soon there
will be Servlet API 4 and 6 specific versions of this class.
grgrzybek added a commit that referenced this issue Sep 20, 2023
@grgrzybek
[#451] server/core module is switched to JakartaEE 9 - all tests pass
95e27ee
grgrzybek added a commit that referenced this issue Sep 20, 2023
@grgrzybek
[#451] server/core module is switched to JakartaEE 9 - all tests pass
1aec317
grgrzybek added a commit that referenced this issue Sep 21, 2023
@grgrzybek
[#451] Switch WAR agents (secured and unsecured) to JakartaEE 9 and u…
b6240b5 
…se Jetty 11
grgrzybek added a commit that referenced this issue Sep 21, 2023
@grgrzybek
[#451] Small fixes in agent/jvm to adjust to JDK11
1a53ac7
grgrzybek added a commit that referenced this issue Sep 21, 2023
@grgrzybek
[#451] Small fixes in agent/osgi to adjust to JDK11
9c43034
@wilkinsona wilkinsona mentioned this issue Sep 25, 2023
Closed
@grgrzybek
Copy link
Contributor

yikes. The problem with Spring support for Jolokia 2.0 is that while we want Servlet API 5+ (jakarta.servlet package) we still want JDK 11...
However there's no Spring Framework version using JakartaEE 9+ while still being JDK11 compliant...

grgrzybek added a commit that referenced this issue Sep 25, 2023
@grgrzybek
[#451] Adjust client/java to JDK11 and Servlet API 5. Tests run on Je…
d44bc52 
…tty 11 now

Some org.eclipse.jetty.http.UriCompliance adjustments were needed (to be
documented soon).
grgrzybek added a commit that referenced this issue Sep 25, 2023
@grgrzybek
[#451] Adjust examples/client-javascript-test-app to JDK11 and Servle…
6e5cca2 
…t API 5. All JS tests work
grgrzybek added a commit that referenced this issue Sep 25, 2023
@grgrzybek
[#451] Adjust examples/spring JDK17, Servlet API 5 and Spring Framewo…
d8c9543 
…rk 6
@tadayosi
Copy link
Member

@grgrzybek

yikes. The problem with Spring support for Jolokia 2.0 is that while we want Servlet API 5+ (jakarta.servlet package) we still want JDK 11... However there's no Spring Framework version using JakartaEE 9+ while still being JDK11 compliant...

Yes, Spring Boot 3 supports only Java 17+. I don't think it's a problem though; we can just support Java 11, 17, ... and Spring Boot can utilise Jolokia 2.0 with Java 17+. The only thing we need to do is just turn off the Spring Boot related subprojects for Java 11, as enabling them for Java 11 doesn't make sense.

@grgrzybek
Copy link
Contributor

Sure - I'll add proper Maven profiles.

grgrzybek added a commit that referenced this issue Sep 28, 2023
@grgrzybek
[Fixes #451] Final cleanup - only jakarta.servlet-api:5.0.0 is used. …
3a74c0c 
…All tests pass
@tadayosi
Copy link
Member

Awesome! 🎉

@grgrzybek grgrzybek mentioned this issue Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] move to JakartaEE
3 participants
@tadayosi @grgrzybek @ExtraCrafTX