Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price Guide errors lately. #335

Closed
ZZJHONS opened this issue Apr 14, 2021 · 17 comments
Closed

Price Guide errors lately. #335

ZZJHONS opened this issue Apr 14, 2021 · 17 comments

Comments

@ZZJHONS
Copy link
Contributor

ZZJHONS commented Apr 14, 2021

Since a few days ago I'm getting errors with Ctrl+G

Sometimes it says that it skipped XX items due to network or errors.

Some other parts show like this:
image

I don't know if this is something from BS, from BL, or from my network (strange...)

@rgriebl
Copy link
Owner

rgriebl commented Apr 14, 2021

That's why I hate HTML scraping:

image

Why would someone remove the New text from the current sales table row?

@rgriebl
Copy link
Owner

rgriebl commented Apr 14, 2021

It's even worse. The above screenshot is from BL's online "Add Item" to shop page for 26603 in black.
The same 26603 in lime shows New: perfectly fine though ... why?

@ZZJHONS
Copy link
Contributor Author

ZZJHONS commented Apr 15, 2021

Oh, Bricklink...

The other part that I was having problems with was 98138 in Glitter Trans-Light Blue on Sunday 11th but now it is working fine in BS and in BL...

If it was a source code error why it only happens sometimes...? Maybe this kind of bug you can email BL directly.

@rgriebl
Copy link
Owner

rgriebl commented Apr 15, 2021

I did already. No answer yet though.

@rgriebl
Copy link
Owner

rgriebl commented Apr 16, 2021

This problem seems be solved now. At least I don't get any broken New: lines anymore ... even tried it with Sylvain's 6000 lot store contents 3 times in a row.
I do however get a lot of 404 not found errors (up to 700 on 6000 lots), but there's no pattern to it (again). I've hacked a simple retry mechanism into BrickStore and now everything seems to download. I hate to do this though, plus I need to do this properly before committing: otherwise we'll have an endless recursion if there happens to be a REAL 404 error ;)

@rgriebl rgriebl pinned this issue Apr 16, 2021
@RedWolves
Copy link

I just ran into this same error while trying to update prices to the price guide. Skipped because of missing price guide records or network errors. The number of items skipped is different each time I run the command.

Running this same command in BrickStock does not produce an error.

@rgriebl
Copy link
Owner

rgriebl commented Apr 17, 2021

BrickStock uses a different interface for downloading PG data. The data you get is wrong though, because that old interface doesn't take VAT into account.

In general, the BL servers are having problems right now: e.g. every time I reload my order list, there are some country flags missing, but - again - the missing flags are never the same.

@rgriebl
Copy link
Owner

rgriebl commented Apr 18, 2021

I've tweaked a few things in the PG DL for build 417. Seems to work for me right now, but the BL servers really are mighty unstable at the moment.
Could you please test if it works out for you as well?

@ZZJHONS
Copy link
Contributor Author

ZZJHONS commented Apr 18, 2021

9053 lots, it took 11:30 minutes to price, it showed just one error, but sorting the price column it showed 10 items with 0,00€ PG for current.

2420
4865
2412b
44728
85970 this one is missing just the current used PG
86208 missing all current and 6-month used
471905-1 same as 86208
49595a this shows all values as -
cty1099 same as 86208
40450-1 same as 86208

Right click update PG doesn't work

@rgriebl
Copy link
Owner

rgriebl commented Apr 18, 2021

2420
4865
2412b
44728
85970 this one is missing just the current used PG
86208 missing all current and 6-month used

which color?
You could also quickly check if it's the original error - the missing condition string: Ctrl+B,Ctrl+C, Add to my inventory, Whole Priceguide

471905-1 same as 86208

Has : instead of Used: (for BOTH current and past 6)

49595a this shows all values as -

Has : instead of New:

cty1099 same as 86208

Has : instead of Used:

40450-1 same as 86208

Has a price > 1000 with , as a thousands separator. Had to change the parsing locale. -> Fixed in next build.

Right click update PG doesn't work

@ZZJHONS
Copy link
Contributor Author

ZZJHONS commented Apr 19, 2021

@rgriebl I emailed you a BSX file with my store's 9k lots.

@rgriebl
Copy link
Owner

rgriebl commented Apr 20, 2021

The latest build seems to be able dodge around all the weird BL server problems at the moment. Please give it a try.

There's one corner case that I could not trigger though: an item where PG data is only available for Used and BL's PG page dropping the Used string. An item like this would end up having the used data as new and no used data in BrickStore.

@ZZJHONS
Copy link
Contributor Author

ZZJHONS commented Apr 20, 2021

Done, it took 9 minutes for 9k lots, but 0 errors :D

@rgriebl
Copy link
Owner

rgriebl commented Apr 20, 2021

Can't do anything about the slowness: I've added HTTP/2 support, enabled HTTP pipelineing and I add SSL session caching. It all helps a little, but the BL servers cannot handle more than 4 requests in parallel right now (6 is the industry standard, as implemented in every browser).

@rgriebl rgriebl closed this as completed Apr 20, 2021
@rgriebl rgriebl unpinned this issue Apr 20, 2021
@rgriebl rgriebl pinned this issue Apr 20, 2021
@rgriebl
Copy link
Owner

rgriebl commented Apr 26, 2021

Finally got a reply from BL support: "[...] there's nothing we can do to assist you and would advise contacting the developers for BrickStore. "
Yeah ... about that.

@rgriebl
Copy link
Owner

rgriebl commented Apr 27, 2021

And another (positive) update from BL support: they can reproduce the bug and the dev team is looking into it. No ETA though due to the ongoing VAT/Brexit work.

@ZZJHONS
Copy link
Contributor Author

ZZJHONS commented Aug 12, 2021

@rgriebl An update from two days ago says they fixed it:

https://www.bricklink.com/help.asp?helpID=2453

@rgriebl rgriebl unpinned this issue Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants