Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'time_taken' of each check to JSON response #296

Open
maszaa opened this issue Apr 22, 2021 · 2 comments
Open

Add 'time_taken' of each check to JSON response #296

maszaa opened this issue Apr 22, 2021 · 2 comments
Assignees

Comments

@maszaa
Copy link
Contributor

maszaa commented Apr 22, 2021

I like to use the JSON response with load balancer. Less data transferred.

But once health check takes long, there is no information, which check took long.

The HTML response has the durations but if you have to read the actual response in terminal etc. it's quite unreadable

plugin.time_taken could be added to the JSON response as well. The JSON response is much more readable as it is (even without any indent).

@codingjoe
Copy link
Collaborator

Hi @maszaa,

If you built it, I will review it 👍

Best,
Joe

@JakobJBauer
Copy link

This is now implemented in v2 of the API in PR #295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants