Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match log in UI with id.resonate.coop #60

Closed
simonv3 opened this issue Sep 17, 2022 · 1 comment · Fixed by #91
Closed

Match log in UI with id.resonate.coop #60

simonv3 opened this issue Sep 17, 2022 · 1 comment · Fixed by #91
Assignees
@simonv3

Comments

@simonv3
Copy link
Collaborator

simonv3 commented Sep 17, 2022

No description provided.

@simonv3
Copy link
Collaborator Author

simonv3 commented Sep 20, 2022 •
edited
Loading

We use EJS for this, which has a critical security vulnerability. The vulnerability has been fixed but koa-ejs hasn't released a new version in 3 years.

Might be worth considering moving off of EJS to do template rendering. This might be an opportunity to improve the situation and use something a bit more popular.

@simonv3 simonv3 self-assigned this Oct 1, 2022
@simonv3 simonv3 mentioned this issue Oct 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonv3 simonv3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: switch to using pug for our templates, do a basic styling pass resonatecoop/api
1 participant
@simonv3