Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] - Ethers - Networks issues #1526

Closed
glitch-txs opened this issue Dec 1, 2023 · 2 comments · Fixed by #1579
Closed

[bug] - Ethers - Networks issues #1526

glitch-txs opened this issue Dec 1, 2023 · 2 comments · Fixed by #1579
Assignees
Labels
bug Something isn't working ethers Issues related to ethers package ethers5 Issues related to ethers5 package

Comments

@glitch-txs
Copy link
Contributor

glitch-txs commented Dec 1, 2023

Link to minimal reproducible example

https://lab.web3modal.com/library/ethers/

Summary

  1. When I'm connected if the chain I want to switch to is not registered in my wallet (it used to throw an error), now it will switch in the dapp but there are no request in the wallet.
    Expected behaviour:
    the modal should can switchNetwork method
    if it fails it should fallback into addNetwork method
    then trigget switchNetwork again

  2. When I use the Network button to connect it should ask me to switch to that chain after connecting, here I select polygon while my wallet is on Arbitrum, but after connecting it doesn't ask me to switch to Polygon

List of related npm package versions

latest

@glitch-txs glitch-txs added bug Something isn't working needs review ethers5 Issues related to ethers5 package ethers Issues related to ethers package and removed needs review labels Dec 1, 2023
@svenvoskamp
Copy link
Contributor

@glitch-txs Closing this one for now as I'm not able to reproduce.

@glitch-txs
Copy link
Contributor Author

I updated the description (copy/paste from slack) with the current behaviour, I also added video demos in slack 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ethers Issues related to ethers package ethers5 Issues related to ethers5 package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants