Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pip-compile): Treat .txt files as pip_requirements files #29491

Conversation

mbudnek
Copy link
Contributor

@mbudnek mbudnek commented Jun 6, 2024

Changes

This fixes a case I missed in #28959 where a lock file uses another lock file as an input file. In that case, we need to treat the input lock file as a pip_requirements file so that we extract the --[extra-]index-url flags from it and pass the correct credentials to pip-compile.

Context

#28959

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

This fixes a case I missed in renovatebot#28959 where a lock file uses another lock
file as an input file.  In that case, we need to treat the input lock
file as a pip_requirements file so that we extract the
--[extra-]index-url flags from it and pass the correct credentials to
pip-compile.
@viceice viceice enabled auto-merge June 6, 2024 17:08
@viceice viceice added this pull request to the merge queue Jun 6, 2024
Merged via the queue into renovatebot:main with commit 8fb3e2f Jun 6, 2024
37 checks passed
@mbudnek mbudnek deleted the pip-compile/treat-txt-as-pip-requirements-file branch June 6, 2024 17:18
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.395.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants