Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix extract function should return packageFile if lock file exists #29380

Open
rarkins opened this issue Jun 1, 2024 · 5 comments
Open

Nix extract function should return packageFile if lock file exists #29380

rarkins opened this issue Jun 1, 2024 · 5 comments
Assignees
Labels
manager:nix Nix package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality

Comments

@rarkins
Copy link
Collaborator

rarkins commented Jun 1, 2024

Describe the proposed change(s).

Currently Renovate discards any package file without detected dependencies, however we should return it (with empty dependencies) also if a lock file exists.

Discussed in #29263

Reproduction (of it working with some local modifications): https://github.com/renovate-reproductions/29263/pull/1/files

@rarkins rarkins added type:bug Bug fix of existing functionality priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others manager:nix Nix package manager labels Jun 1, 2024
@RahulGautamSingh
Copy link
Collaborator

RahulGautamSingh commented Jul 16, 2024

We will need to add and export extractAllPackageFiles function in the nix manager to handle asynchronous operations required for this fix, right?

@rarkins
Copy link
Collaborator Author

rarkins commented Jul 16, 2024

I don't think that's necessary

@rarkins rarkins removed the priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others label Jul 16, 2024
@RahulGautamSingh
Copy link
Collaborator

We can't add file reading to the extractPackageFile fn, since it is defined as normal function. Whar other approach would be to check the lockfile exists?

@rarkins
Copy link
Collaborator Author

rarkins commented Jul 16, 2024

Maybe you're right. But I'll self assign this as I solved it earlier and have a stash saved somewhere

@rarkins rarkins self-assigned this Jul 16, 2024
@rarkins rarkins added the priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others label Jul 16, 2024
@viceice
Copy link
Member

viceice commented Jul 20, 2024

We can't add file reading to the extractPackageFile fn, since it is defined as normal function. Whar other approach would be to check the lockfile exists?

extractPackageFile can be async too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manager:nix Nix package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants