Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pip_requirements): Move flags extraction to common.ts #29360

Conversation

mbudnek
Copy link
Contributor

@mbudnek mbudnek commented May 30, 2024

Changes

The pip-compile manager will need to extract flags from pip requirements files in #28959, so move that code into a common.ts

Context

#28959 (comment)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

The pip-compile manager will need to extract flags from pip requirements
files in renovatebot#28959, so move that code into a common.ts
@rarkins rarkins added this pull request to the merge queue Jun 1, 2024
Merged via the queue into renovatebot:main with commit 6797e01 Jun 1, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.385.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mbudnek mbudnek deleted the refactor/pip-requirements-extract-flags-common branch June 3, 2024 13:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants