Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: automate docs for releaseTimestamp and sourceUrl support #29225

Merged
merged 3 commits into from
May 29, 2024
Merged

docs: automate docs for releaseTimestamp and sourceUrl support #29225

merged 3 commits into from
May 29, 2024

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

  • Add details about releaseTimestamp and sourceUrl support in datasource docs
  • Implement a table to show this information
  • Use proper headings for different sections (datasource & versioining)

Context

Closes: #28948

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

RahulGautamSingh
RahulGautamSingh commented May 24, 2024
View reviewed changes
tools/docs/utils.ts Outdated Show resolved Hide resolved
RahulGautamSingh
RahulGautamSingh commented May 24, 2024
View reviewed changes
tools/docs/utils.ts Outdated Show resolved Hide resolved
@RahulGautamSingh
Apply suggestions from code review
bae1a2c 
remove extra whitespace
@rarkins @HonkingGoose
Update index.ts
c073db2 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
secustor
secustor reviewed May 27, 2024
View reviewed changes
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else LGTM

tools/docs/datasources.ts Show resolved Hide resolved
viceice
viceice reviewed May 27, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you share some screenshots about the changes? vscode preview should be enough.

tools/docs/datasources.ts Show resolved Hide resolved
@RahulGautamSingh
Copy link
Collaborator Author

can you share some screenshots about the changes? vscode preview should be enough.

screenshots

@secustor secustor added this pull request to the merge queue May 29, 2024
Merged via the queue into renovatebot:main with commit 6dd189e May 29, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.381.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@secustor secustor secustor approved these changes

@rarkins rarkins Awaiting requested review from rarkins

@HonkingGoose HonkingGoose Awaiting requested review from HonkingGoose

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automate datasource docs for sourceUrl, releaseTimestamp
6 participants
@RahulGautamSingh @renovate-release @viceice @secustor @HonkingGoose @rarkins