-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for git refs for vendir #28084
feat: add support for git refs for vendir #28084
Conversation
fix: remove git, not installable on the fly fix: add back types.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please make the fixtures condensed in a separate PR? so we've less changes for the new feature.
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
You had asked me to condense the fixtures in a previous comment. So it feels like doing 1/3 of the condensing here just because and then a second PR is... Odd? Either I follow the pattern for vendir from the previous PR of having separate fixtures and will condense if desired completely in a separate PR. Or I'll do it now. But leaving it part way done/inconsistent doesn't seem right. |
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😉
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
🎉 This PR is included in version 37.274.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Changes
Adds support for gitRefs (but not revisionSelections/Ranges) to the Vendir Manager. Vendir supports lots of different upstream/sources this is a commonly used one.
Context
After merging support for helmCharts via Vendir this PR adds support for gitRefs as well
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: