-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: separateMultipleMinor #24538
feat: separateMultipleMinor #24538
Conversation
Not sure if this second approach is right either 323a247 , but moved the logic away from the user configurable template over to a replace on But i suppose this is still an assumption its part of the template that is configurable. Will update the tests when i have a confirmation this way is the correct way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
sorry forgot about this pr thanks for the nudge |
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Any chance to have this merge soon? |
needs deconflicting |
🎉 This PR is included in version 37.269.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
since they release breaking changes in minor versions renovatebot/renovate#24538
Changes
Attempt at supporting the
seperateMultipleMinor
Will follow up with one for patch also when/is this is merged
Context
My usecase is seperating eks versions as individual prs as they are "minor versions" but you must go 1 by 1 during an update
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
below is it run for my exact usecase happy to try others if suggested
https://github.com/phyzical/renovate-tester/pulls
It works for my tiny usecase.
but I think ive done this wrong though... as i felt like i was fighting the
{{#if separateMinorPatch}}{{#if isPatch}}
logic so open to feedbacki also couldn't find an example of
separateMultipleMajor
being run from a multiple branch test context, there just seems to be hardcoded tests against static templates. or have i not looked hard enoughThanks!